search

sul-dlss-deprecated / sdr-preservation-core

Robots for ingesting objects into SDR Preservation Core -- replaced by preservation_robots
Other
1 stars 0 forks source link

disposition experimental multiplexing code #68

Open jmartin-sul opened 7 years ago

jmartin-sul commented 7 years ago

it seems that there may be some code in this project that resulted from an incomplete trial of some multiplexing functionality. we should either remove this code, or finish the experiment and add any necessary polish to make it production-worthy.

e.g.: https://github.com/sul-dlss/sdr-preservation-core/blob/d7870c1fc7b3afa1934e276d8bbd1fc67df886c9/bin/register_objs.rb

dazza-codes commented 7 years ago

@jmartin-sul - in the past, that script has been used to run integration tests and may still serve a role in that process, although there is also an alternative way of doing integration tests by using Argo to open/close an object.

jmartin-sul commented 7 years ago

ah, good to know, thanks @darrenleeweber.

so... are you aware of any code remaining on master that was leftover from that test project? was it something that was partially implemented on the develop branch, and then kept as part of the recent merge to master? or should i just close this ticket?

dazza-codes commented 7 years ago

Not sure so we could leave this open to investigate later. I think there was some initial tests of the optimal number of robots to run on one machine (scale up) but there were no tests of the optimal number of robots to run across multiple machines (scale out/horizontally). Hence, the SDR-PC prod box is a beefy machine (scaled up) and we only have one of them, so that's a single point of failure. I believe we need to investigate the options to scale-out across multiple machines.