search

sul-dlss-deprecated / swap

(meant as a replacement for sul-dlss/openwayback but not yet there) Java application to query and access archived web material -- the code for the Stanford Web Archiving Portal (SWAP). Overlay of iipc/openwayback.
Other
1 stars 0 forks source link

swap: stanford vs. upstream version numbering #28

Open ndushay opened 6 years ago

ndushay commented 6 years ago

We need an easy way to designate in a single place the upstream tagged version and, separately, the version of our localizations.

Possibly properties in the root pom.xml that are referenced by the other pom.xml files?

ndushay commented 6 years ago

This is implemented and works, but

these warnings from maven can be ignored:

...
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.netpreserve.openwayback:openwayback-cdx-server:war:2.0.0
[WARNING] 'version' contains an expression but should be a constant. @ org.netpreserve.openwayback:openwayback-cdx-server:${upstream.version}, /Users/ndushay/sul-dlss-github/swap/upstream-cdx-server/pom.xml, line 18, column 12
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.stanford.dlss:upstream-wayback-core:jar:2.0.0SUL1.0.0
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:upstream-wayback-core:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/upstream-wayback-core/pom.xml, line 15, column 12
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.stanford.dlss:swap-wayback-core:jar:2.0.0SUL1.0.0
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:swap-wayback-core:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/wayback-core/pom.xml, line 15, column 12
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.stanford.dlss:swap-wayback-webapp:war:2.0.0SUL1.0.0
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.stanford.dlss:swap-distrib:war:2.0.0SUL1.0.0
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for edu.stanford.dlss:stanford-web-archiving-portal:pom:2.0.0SUL1.0.0
[WARNING] 'version' contains an expression but should be a constant. @ edu.stanford.dlss:stanford-web-archiving-portal:${stanford.version}, /Users/ndushay/sul-dlss-github/swap/pom.xml, line 20, column 12
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
...

these warnings from maven perhaps can be avoided? from building dist target:

...
[INFO] --- maven-assembly-plugin:3.0.0:single (default) @ swap-distrib ---
[INFO] Reading assembly descriptor: assembly/distribution.xml
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'edu.stanford.dlss:swap-wayback-core'
o  'edu.stanford.dlss:upstream-wayback-core'

[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o  'edu.stanford.dlss:swap-wayback-core'
o  'edu.stanford.dlss:upstream-wayback-core'

[INFO] Building war: /Users/ndushay/sul-dlss-github/swap/dist/target/swap-dist-2.0.0SUL1.0.0.war
...