swap: get all stanford changes into wayback-core

[ndushay]

I have been focused on getting the plumbing working for our builds, such that this git repo can have ONLY stanford modified files, and we also have a way to build deployable artifacts.

I did not cover all the stanford modifications to the wayback-core module. (I did get all the stanford localizations for wayback-webapp and we have no localizations for wayback-cdx-server).

In the attached spreadsheet, you can ignore all but the wayback-core yellow highlighted files.

openwayback locally modified.xlsx

Note already existing commit patterns as a means of trying to document the specific localizations:

For each file:

• start with vanilla IIPC 2.0 version
• add local mods as separate commits if they can be split out by purpose or section

[ndushay]

progress report: I thought I had all the localizations ported over for wayback-core and wayback-webapp (and we have no changes for wayback-cdx-server), but the new swap war file created is not working right. Currently seeing the following in tomcat logs (catalina.out):

Aug 10, 2017 11:52:02 AM org.apache.catalina.core.StandardContext filterStart
SEVERE: Exception starting filter RequestFilter
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'fastArchivalSAXDelegator' defined in URL [file:/usr/share/tomcat/webapps/ROOT/WEB-INF/ArchivalUrlReplay.xml]: Invocation of init method failed; nested exception is java.lang.NullPointerException
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1420)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:519)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:456)
    at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
    at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
    at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290)
    at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:192)
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:585)
    at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:895)
    at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:425)
    at org.springframework.context.support.FileSystemXmlApplicationContext.<init>(FileSystemXmlApplicationContext.java:140)
    at org.springframework.context.support.FileSystemXmlApplicationContext.<init>(FileSystemXmlApplicationContext.java:84)
    at org.archive.wayback.util.webapp.SpringReader.readSpringConfig(SpringReader.java:59)
    at org.archive.wayback.util.webapp.RequestFilter.loadRequestMapper(RequestFilter.java:175)
    at org.archive.wayback.util.webapp.RequestFilter.init(RequestFilter.java:105)
    at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:279)
    at org.apache.catalina.core.ApplicationFilterConfig.getFilter(ApplicationFilterConfig.java:260)
    at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:105)
    at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4958)
    at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5652)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:145)
    at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:899)
    at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:875)
    at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:652)
    at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:1092)
    at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1984)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
    at java.util.Properties$LineReader.readLine(Properties.java:434)
    at java.util.Properties.load0(Properties.java:353)
    at java.util.Properties.load(Properties.java:341)
    at org.archive.wayback.archivalurl.StandardAttributeRewriter.loadRules(StandardAttributeRewriter.java:239)
    at org.archive.wayback.archivalurl.StandardAttributeRewriter.init(StandardAttributeRewriter.java:202)
    at org.archive.wayback.archivalurl.FastArchivalUrlReplayParseEventHandler.init(FastArchivalUrlReplayParseEventHandler.java:108)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeCustomInitMethod(AbstractAutowireCapableBeanFactory.java:1544)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1485)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1417)
    ... 30 more

[ndushay]

closing this in favor of #30