search

sul-dlss-deprecated / taco

Apache License 2.0
10 stars 7 forks source link

Have Deposit File write valid File metadata #379

Closed cmharlow closed 6 years ago

jcoyne commented 6 years ago

By this we mean, run the JSON through the schema validation prior to persisting into dynamodb?

cmharlow commented 6 years ago

Well, and first actually capturing all the fields we know are required for a file.

cmharlow commented 6 years ago

The latest PR stores invalid files now.

jcoyne commented 6 years ago

@cmh2166 do we have defaults defined for the required fields? The ones that aren't immediately obvious to me are:

label
access.access
access.download
administrative.sdrPreserve

May I suggest we copy these values from the containing fileset upon deposit?

jcoyne commented 6 years ago

After #396 goes in, we would still need to set a "label" for it to be valid. What should we set that to?

cmharlow commented 6 years ago

label == filename at the moment / for this work cycle.