search

sul-dlss-deprecated / taco

Apache License 2.0
10 stars 7 forks source link

Files are not valid deposit resources (for `/resource`) #382

Closed jcoyne closed 6 years ago

jcoyne commented 6 years ago

Instead they are deposited via a POST to /v1/file

Per discussion after standup 4/6/18

cmharlow commented 6 years ago

Let’s be extra clear here given recent confusion and a misleading title:

Files should not be deposited via a POST to the ‘/resource’ route. They should be deposited via a POST to ‘/file’ route. This is from sprint 0 discussions.

Updates to files (currently metadata only) are like any resource a PATCH to ‘/resource/{Id}’ route. We started work on update file (binary) but that was held back given team misunderstanding of current work.

On the ‘/file’ POST, a File is a valid deposit resource. But it builds and validated File metadata differently. Currently that build is invalid in master (it does not follow the MAP spec).

This is a change for the ‘/resource’ POST route and how it handles validations, which doesn’t include Files.

jcoyne commented 6 years ago

@cmh2166 yes, that is correct.

cmharlow commented 6 years ago

Cool. Wasn’t asking, but clarifying for you and others - again, given confusion and unclear PR title.