search

sul-dlss-deprecated / taco

Apache License 2.0
10 stars 7 forks source link

adding sample PDF for running updated file load example in readme #424

Closed cmharlow closed 6 years ago

cmharlow commented 6 years ago

not required for merging, just adding example file for file upload

jcoyne commented 6 years ago

I'm not keen on storing binaries in this repo, especially ones we don't need (this could be any binary file). Could we add instructions on how to pull this file (using curl) from elsewhere instead?

cmharlow commented 6 years ago

@jcoyne just curious, why no example binaries in a repo?

jcoyne commented 6 years ago

@cmh2166 binaries make the git repo grow very big, it's not well suited to storing binaries as they they have to basically be stored as full files, even if we decide to remove it from HEAD, it'll have to hold that file in case you want to checkout the old version. This is something we've run into in the hydra project https://github.com/samvera/hydra-jetty

jcoyne commented 6 years ago

Can we add this to the readme instead?

curl -L https://github.com/samvera/hyrax/raw/master/spec/fixtures/hyrax/hyrax_test4.pdf -o myfile.pdf
cmharlow commented 6 years ago

That’s fine for me

jcoyne commented 6 years ago

Superseded by #431