search

sul-dlss-deprecated / taco

Apache License 2.0
10 stars 7 forks source link

Fix generator to accomodate array types #435

Closed jcoyne closed 6 years ago

jcoyne commented 6 years ago

The go generate has been broken since #400 was merged. it was unable to handle:

"type": ["string", "null"]
cmharlow commented 6 years ago

I don't understand what exactly this is adding to the generated MAPs data. I do see evidence that maybe we should revisit the regenerate data upon deploy question again since a lot of the generated MAP changes are just from not running this often with PRs that effect the MAPs.

jcoyne commented 6 years ago

@cmh2166 it's not adding anything, it's just allowing the generator to work, which it doesn't do on master