search

sul-dlss-deprecated / taco

Apache License 2.0
10 stars 7 forks source link

Instead of installing python on a go image, use a python image #452

Open atz opened 5 years ago

atz commented 5 years ago

Thanks to circle's composition of the underlying image, we also don't have to install jq, libyaml, pip, etc. They are already available on the (local-to-circle) cached image. The only unique requirement is awscli.

Note: doesn't even require checkout because nothing involves the actual app code!

The ability to use different images for different "jobs" in Circle is a major strength. Here's where we applied this strategy in sinopia: https://github.com/LD4P/sinopia_profile_editor/pull/123/files#diff-1d37e48f9ceff6d8030570cd36286a61R81

This change cuts as much as half the execution time off the "deploy_to_demo" job, and gives the Circle config a more tightly defined responsibility.