sul-dlss-deprecated / triannon

Rails engine for working with storage of OpenAnnotations stored in Fedora4
Other
13 stars 1 forks source link

Feature/omniauth #199

Closed dazza-codes closed 9 years ago

dazza-codes commented 9 years ago

Proposing to merge this branch with master (prefer it was develop, but that doesn't exist), so that further work on using omniauth can hack an oauth2 provider. This branch is a bare-bones addition of omniauth that is completely hacked to suit the proposed SearchWorks use case for authorization to get containers. It's not using oauth2 at present, only the base :developer provider. But at least that is working (see /auth/developer in the UI and note that is is already rigged to only accept a couple of 'authorized apps').

dazza-codes commented 9 years ago

@ndushay and @cbeer - please consider as a bare-bones start to working with omniauth, much more work is required to use an oauth2 provider rather than the simple developer used here.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.07%) to 99.61% when pulling 15985332730041a6c026a577375421d1f205df3b on feature/omniauth into 06d8d978f856399c9fa70e0c46a9d70856ffeaf0 on master.

dazza-codes commented 9 years ago

Closing this PR after discussion to implement a different solution that follows IIIF patterns, see specs and related code: