sul-dlss-deprecated / triannon

Rails engine for working with storage of OpenAnnotations stored in Fedora4
Other
13 stars 1 forks source link

Errors on rails 4.2.3 #206

Closed dazza-codes closed 9 years ago

dazza-codes commented 9 years ago

.gemspec is pinned to rails 4.2.2 (actually just actionpack 4.2.2 is the issue), because errors arise in 4.2.3, i.e.

1) Triannon::AnnotationsController#create creates a new annotation from the body of the request
     Failure/Error: post :create, ttl_data, anno_root: @root_container
     NoMethodError:
       undefined method `_run_save_callbacks' for #<Triannon::Annotation:0x0000000b00b5d0>
     # ./app/models/triannon/annotation.rb:43:in `save'
     # ./app/controllers/triannon/annotations_controller.rb:84:in `create'
     # /home/travis/.rvm/gems/ruby-2.2.2/gems/actionpack-4.2.3/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
dazza-codes commented 9 years ago

Note that fixing the rails gem to 4.2.2 in .gemset did not fix the travis builds, so it's not entirely clear that 4.2.2 vs. 4.2.3 is the source of the problems that motivated this issue in the first place.

dazza-codes commented 9 years ago

The Annotation class might need to be updated for rails 4.2.3, see

dazza-codes commented 9 years ago

This might be fixed by https://github.com/sul-dlss/triannon/commit/407f85c89259b71a814ea329f6d5369f71213d0d

dazza-codes commented 9 years ago

Migrating engine cart concerns into https://github.com/cbeer/engine_cart/issues/23

dazza-codes commented 9 years ago

@ndushay also committed a fix in e50baad4341be504a7682990ae90b276af69c61b

dazza-codes commented 9 years ago

The fixes have passed a build in travis, so closing this issue as fixed (mucho fixed).