Update color of Login banner with SUL-oriented color

sul-dlss-deprecated / universalviewer

The Universal Viewer is a community-developed open source project on a mission to help you share your content with the world

http://universalviewer.io

Other

0 stars 1 forks source link

Update color of Login banner with SUL-oriented color #31

Closed ggeisler closed 6 years ago

ggeisler commented 6 years ago

(Broken out from #24)

Change the background color of the information banner to something in the Stanford color palette (and maybe some with less contrast, so the lazy, unauthenticated user can use the viewer without closing the banner and not be too distracted by it).

Cardinal red was discussed and looks very Stanfordy, though it was brought up that it might not have enough contrast with the adjacent brown top bar.

edsilv commented 6 years ago

You should just need to add a @brand-warning variable with the desired colour to your theme: https://github.com/sul-dlss/uv-en-GB-theme/blob/master/variables.less

mejackreed commented 6 years ago

UV Default

EAAB00 "Sun"

EFC040 Derived tint from Sun

007c92 "Lagunita"

8d3c1e "Redwood"

175e54 "Palo Alto"

ggeisler commented 6 years ago

I had made a minor argument for a color that jumps out less than the original default color, just to make it easier for users who might ignore the banner to continue using the viewer. From that point of view, Redwood works in that the contrast to the background is less sharp than the other options.

However, I don't feel too strongly about this. If we went with any of the last three I think we might need to also change the close "X" and the button to white. Are those colors also easily overridable?

If not, I like the Sun and the variant of that; they wouldn't require any changes to the button and close icon. It's just a bit harder to focus on the viewer when the stronger color banner is visible.

Maybe @jvine has a firmer opinion to help us make a decision.

mejackreed commented 6 years ago

@ggeisler yes we can easily change the X and other styling/button colors

jvine commented 6 years ago

Looking at it in the context of a black and white photo is maybe misleading, too - any colour we choose is going to interfere with some images. (Speaking of, are we sticking with the dark brown frame? I've really come to hate it.) That said:

we have typically used Cardinal for things relating to authentication
I've been thinking of the non-logged-in state as a preview that doesn't have much utility in itself, so a really obvious "this isn't everything; you need to login" banner seems appropriate - but maybe that's not realistic?
I find Redwood depressing
I like Sun and Lagunita

How's that for firm?

ggeisler commented 6 years ago

@jvine I thought you didn't like Cardinal in this content? If that is not an issue, that makes the most sense to me. Otherwise I'd vote for Sun or the variant of it.

I had created another ticket to deal with the text on the banner (related to your second bullet) but it was closed: https://github.com/sul-dlss/universalviewer/issues/32. I think it was closed due to a resolution of how the string is configurable, but my intent was to have a separate ticket to deal with the wording we want to present on the banner. So I guess we could create a new ticket for that.

mejackreed commented 6 years ago

Reopened #32 @ggeisler .. I feel like if we want to make those modifications, feel free to make a suggestion there. This will be done in stacks.

mejackreed commented 6 years ago

Thanks for the feedback!

So here I have "Dark Red" implemented. Imagine the close "X" is white