search

sul-dlss-deprecated / universalviewer

The Universal Viewer is a community-developed open source project on a mission to help you share your content with the world
http://universalviewer.io
Other
0 stars 1 forks source link

remove entire non-redirect logic for auth popup in our fork instead o… #37

Closed aeschylus closed 6 years ago

aeschylus commented 6 years ago

…f in main UV or SUL-Embed

aeschylus commented 6 years ago

I know we wanted to avoid maintaining this fork, but in the absence of completely fixing the Auth flow in UV to allow our edge-case of using the info bar instead of the auth dialogue, this is the only way to completely remove it.

There will still be issues with the browser's cache and the login bar. If the user dismisses the login bar on a page, it will not ever appear again on that page. The user will need to visit a completely new page before it will prompt again to log in with the top bar. This is not ideal, but there is a certain logic to it, so I would submit this solution as the best for immediate launch.

I will have another PR incoming that hard-codes the auth pop-up message instead of removing it, since the popup does not currently accept a message or a configuration (to configure this could/should probably be a contribution to UV proper), nor does it seem possible to detect the emergence of the popup and place the text in externally through SUL-Embed without a timeout (that would affect performance for all users), since there is no access to the running instance.