search

sul-dlss-deprecated / universalviewer

The Universal Viewer is a community-developed open source project on a mission to help you share your content with the world
http://universalviewer.io
Other
0 stars 1 forks source link

Mini-map navigator renders inconsistently for multi page objects #49

Closed jkeck closed 6 years ago

jkeck commented 6 years ago

The mini-map navigator has some rendering quirks after updating the to the latest UV master branch (a couple weeks ago). When I say "mini-map navigator" what I mean is the UI element highlighted in the red box in the screenshot below.

mini-map-navigator

Steps to reproduce (in UAT)

  1. Go to a record that renders a viewer (cc842mn9348)
    • Note that the mini-map navigator does show up on the first page
  2. Navigate to the 2nd page (using the arrow button navigation in the viewer or clicking on an item in the Contents side panel).
    • Note that the mini-map navigator does not show up on the 2nd, or any subsequent page

Current Behavior (in UAT)

The mini-map navigation does not show up on any subsequent page.

Expected Behavior (which you can see in production)

The mini-map navigation continues to render through paging to different documents.

Other Information

You can get the mini-map navigation to show up be re-sizing the page. This makes me thing that this may have something to do w/ the changes that were made to the responsive features of UV. It renders correctly on initialization, and on resize, but it looks like whatever is checking on page navigation to see if the mini-map should render is either getting the wrong state or not executing at all.

mejackreed commented 6 years ago

I think that this is the commit that removed the navigator based on sizing of the window: https://github.com/UniversalViewer/universalviewer/commit/28b5b21402a04f9f242594b3eab326a9faa4dbb9

My understanding is that the mini navigator will only render if the "METRIC" is desktop.

mejackreed commented 6 years ago

@ggeisler is their a certain range of width/heights that we want the navigator to appear on? We can likely make this modification using an updated config.

jkeck commented 6 years ago

@mejackreed we have updated our variables to disable all other screen widths and should be getting this feature in all modalities. sul-dlss/uv-en-GB-theme#1

You'll notice in the example above that the rendering of the navigator can be inconsistent based on which canvas you're loading or if you've resized the viewer/browser (when it is expected to be showing at all times).

I would be happy to jump on a screenshare to show you what we're seeing (since it can also be browser specific in initial testing).