search

sul-dlss-deprecated / universalviewer

The Universal Viewer is a community-developed open source project on a mission to help you share your content with the world
http://universalviewer.io
Other
0 stars 1 forks source link

Update icons for better display on high-res devices #8

Open ggeisler opened 6 years ago

ggeisler commented 6 years ago

The icons don't appear to be ones that will scale well. We should update to SVG or other strategy that will ensure icons look good on high-res devices.

bugatti_type_51a__road__amp__track_salon_january_1957___stanford_digital_repository

mejackreed commented 6 years ago

Updated footer icons here: https://github.com/sul-dlss/sul-embed/pull/792/commits/e51e117fecaa4e54d2b22bc12a64699c7b91e421

edsilv commented 6 years ago

SVG sounds good to me. It might have to wait until UV v4 though as that's where we start using things that aren't IE10 compatible (webcomponents).

https://caniuse.com/#feat=svg

tomcrane commented 6 years ago

@mejackreed Are those inline CSS base64 pngs the higher res versions?

mejackreed commented 6 years ago

So what I did for our version was to use a double resolution image in the base64 inline image and then just resize down with css. See:

https://github.com/sul-dlss/uv-en-GB-theme/commit/ce01776410d432b6faa1072279c99793a13c0d86

and then

https://github.com/sul-dlss/uv-en-GB-theme/commit/11f4abce7405befb5f1b9596d32d38846192922f