sul-dlss / SearchWorks

SearchWorks (Stanford University Libraries)
http://searchworks.stanford.edu
Other
48 stars 10 forks source link

Remove “At the library” section for coordinate online records; Add coordinate library to Available online card #3944

Closed dbranchini closed 8 months ago

dbranchini commented 9 months ago

Problem Statement:

We have an inconsistent display for eResource records without a physical volume associated with the record.

SUL - At the Library is not displayed:

Screenshot follows:


Coordinate libraries - At the Library is displayed:

Libraries/records are: Business: The emotional brain…; Lane Medical: Brain communications; Law: Breakthroughs in brain research…

Screenshots from above records follow:

Proposed Solution:

NOTE: This is for eResource-only records. For example, it would not apply this record - https://searchworks.stanford.edu/view/15095727.

See the screenshot and comp:

At the library/Unknown "Flow" on the Figma sidebar** https://www.figma.com/proto/W3GIkPyGLeO5xMojmkZuTX/SearchWorks?page-id=0%3A1&type=design&node-id=308-1254&viewport=-62%2C-2146%2C0.25&t=iNqOsgsz6STHXHkf-1&scaling=min-zoom&starting-point-node-id=308%3A1254&show-proto-sidebar=1&mode=design

cbeer commented 9 months ago

If the eResource-only record is “owned” by Business, Lane Medical & Law

In FOLIO, I think this boils down to "show the library name if the holdings location campus isn't SUL". It also includes Hoover, but we don't think Hoover has any e-resource only records.

saseestone commented 9 months ago

Darcy sent this to stakeholders for feedback today. Due date for feedback is EOD Friday, Feb. 16.

dnoneill commented 9 months ago

I have the first part done. The second part (adding the location is a little tricky and I am not sure we want to do it. The big problem is we don't have a good way (that I can figure) to know if the link is a external link or internal so we could have the location showing for things we don't have any power over like hathitrust. While I could write some conditionals to check I am not sure how many sites we link to externally and I am not sure that the library who holds it is especially useful to the user.

Image Image

dbranchini commented 9 months ago

Also, this needs to be addressed on search results.

dnoneill commented 9 months ago

@dbranchini @saseestone I updated as discussed. I built in some logic that makes sure that the library does not show up in the online section if there are physical copies. i.e. https://searchworks.stanford.edu/view/14640037. Also are we considering Green a branch library? Is this something we need to worry about displaying?

dbranchini commented 9 months ago

No, Green is not a coordinate library, so it shouldn't be included. It should be Lane, Law, Hoover, and Business only (those are all considered coordinate libraries) that have these types of associations with electronic resources. It's my understanding the rest should always be SUL electronic holdings (not associated with a particular library). BUT the record you refer to above is confusing to me. I looked it up in FOLIO, and it's showing no SUL electronic holdings or items and only an aged-to-lost book, so I'm not sure where the online items are coming from in SearchWorks. @cbeer or @saseestone, maybe you have insight on this?

cbeer commented 9 months ago

Instead of special cases for those 4, I think my comment last week still applies:

In FOLIO, I think this boils down to "show the library name if the holdings location campus isn't SUL". It also includes Hoover, but we don't think Hoover has any e-resource only records.

https://github.com/sul-dlss/SearchWorks/issues/3944#issuecomment-1944365950

The online item comes from the MARC 856 field, doesn't it? I believe FOLIO item records were only created for electronic resources if there was no physical item

dnoneill commented 9 months ago

@dbranchini @saseestone If there is only a google preview of the online item (no other links) I don't have it including the library name. Do you want this behavior or do you want it to show up if there is a google preview only?

cbeer commented 9 months ago

I don't /think/ that case (should) exist. If we don't have a link from the MARC or a physical item, I think we wouldn't index the record in the first place.

dnoneill commented 9 months ago

@cbeer I am guessing this is only gets tripped when there is a physical location as well then? https://github.com/sul-dlss/SearchWorks/blob/bf6f332831111056e113df9f97352fb1e8655866/app/components/access_panels/online_component.html.erb#L45-L49