add integration tests for indexing

sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry

Other

20 stars 5 forks source link

add integration tests for indexing #4331

Open ndushay opened 6 months ago

ndushay commented 6 months ago

[x] identifiers https://github.com/sul-dlss/argo/pull/4343
[x] tags https://github.com/sul-dlss/argo/pull/4345
[ ] titles https://github.com/sul-dlss/argo/pull/4361
[ ] authors
- [ ] including contributor orcids
[ ] topic
[ ] publisher / publication place
[ ] catchall
[ ] date picker / date fields
[ ] collection titles
[ ] searchworks facet values

jcoyne commented 5 months ago

The two tests that have been added so far have proved to be flaky and are detrimental to the developer experience. I propose that instead, a new integration test suite (that is just run in CI) is developed. This can test all of the integrations without making Argo hard to work on and without impacting the state of the stage servers.

lwrubel commented 5 months ago

For the short term, we'll mark these tests to be skipped in CI. https://github.com/sul-dlss/argo/issues/4380.