sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry

Other

20 stars 5 forks source link

Move some initialization from CatalogController to MilestonesPresenter. #4504

Closed justinlittman closed 2 months ago

justinlittman commented 2 months ago

Why was this change made?

How was this change tested?

jcoyne commented 2 months ago

This goes contrary to the presenter pattern in Rails. Because presenters should not make API calls, they are a data object for presentation. Maybe you should rename it?

see https://www.rubyguides.com/2019/09/rails-patterns-presenter-service/