NilModels are largely vestigial. They were necessary when our cocina implementation was less mature. However:
They are only partially implemented. That is, only some part of the codebase provides special handling for them.
They are virtually untested.
Our cocina implementation is very stable.
Further, we should not expect cocina validation errors or DSA find cocina errors to happen, such that they need to be rescued. Again, it is doubtful that they would be rescued correctly and are largely untested. At this point, it is better to treat them as unhandled exceptions.
Why was this change made?
NilModels are largely vestigial. They were necessary when our cocina implementation was less mature. However:
Further, we should not expect cocina validation errors or DSA find cocina errors to happen, such that they need to be rescued. Again, it is doubtful that they would be rescued correctly and are largely untested. At this point, it is better to treat them as unhandled exceptions.
How was this change tested?