Argo history link should link to pages for all versions

andrewjbtw commented 2 months ago

The Argo item show page has a history section that lists all versions of an item. When we enable the display of previous versions, that list should link to each of the versions. Do not show a link for the version currently being viewed (system version 5 in the screenshot below):

The current click behavior of that list is odd because clicking on a title collapses the section, which can be disorienting. Instead, change the collapse behavior:

Add an icon for expand/collapse to the left of the version description (see wireframe)
Do not collapse the list when someone clicks on the title - only expand/collapse via the icon

(Figma link)

Additional notes

Versions that we can't render: I don't think we can show old versions that pre-date the new versioned model. If a previous version isn't available, don't put a link in the text. We'll need to communicate that limit to users. It's my understanding from planning discussion that we will be able to show old (system) versions going forward.
Content types: we're limiting the initial use of public versions to the "file" content type. This is largely because there are many questions around what we can render in the viewers. Argo has no viewers, so it should theoretically be possible to show old system versions regardless of content type. Please correct me if I'm wrong.

justinlittman commented 2 months ago

When did system version display get added to the scope of this WC? All of our Argo and DSA work has been on the assumption that we would be displaying user versions, but not system versions. This is a significant change in scope.

andrewjbtw commented 1 month ago

It was discussed in planning before the workcycle began and the suggestion that it would be possible based on the new model came from the developer side.

justinlittman commented 1 month ago

Yes, we said it was possible. However, possible is different from in-scope, especially when we've proceeded with the specs that we had.

andrewjbtw commented 1 month ago

This is why I said in Slack this would need some discussion in the next planning.

justinlittman commented 1 month ago

Super.

aaron-collier commented 1 month ago

From planning: on file list for previous versions show the file list but do not provide links.

justinlittman commented 1 month ago

Blocked by https://github.com/sul-dlss/dor-services-app/issues/5147

sul-dlss / argo

Argo history link should link to pages for all versions #4521