sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry
Other
20 stars 5 forks source link

Update visual design of header (this is a design component) #4529

Closed astridu closed 1 month ago

astridu commented 1 month ago

Current header:

image

New header (for reference, this is the same style as the Preassembly header that was just updated):

image
astridu commented 1 month ago

Also an example of our header template here if this helps: https://sul-dlss.github.io/component-library/header/

jcoyne commented 1 month ago

@astridu where would you put the "Logged in as " in the new design? Are we going to keep the register drop down, or does that functionality move elsewhere?

Screenshot 2024-07-10 at 8 51 53 AM

Is the change from "Bulk Actions" to "Bulk action" (plural to singular) intentional?

I don't believe Argo currently has a logout page. What would that look like?

astridu commented 1 month ago
  1. I didn't think we needed the 'logged in as', but let me know if there is a compelling reason to keep it.
  2. Sorry, the mockup was just missing the drop down icon. image
justinlittman commented 1 month ago

Is this design supposed to be responsive? (And if so, how?)

astridu commented 1 month ago

Yes. This is what we have, but I need to doublecheck on the mobile view bc we are currently working on that one.

image
jcoyne commented 1 month ago

@astridu the "logged in as" is important if you're impersonating some other user/group.

astridu commented 1 month ago

ok, will work on it.

astridu commented 1 month ago

I added the 'logged in as' back. It's next to the logout link. As for making this responsive, the EarthWorks team is working on this same header and will have the responsive design. I'm wondering if you want to wait until they have it completed and copy it?

image
jcoyne commented 1 month ago

I want to note that this header is part of the component library: https://sul-dlss.github.io/component-library/header/ although we don't yet have a dark-stone version.

jcoyne commented 1 month ago

We should be able to just replace the palo-alto-dark class we have in the component library with a stone-dark class described as:

:root {
  --stanford-stone-dark-rgb: 84, 73, 72;
}
.stone-dark {
  --bs-dark-rgb: var(--stanford-stone-dark-rgb);
}
aaron-collier commented 1 month ago

@astridu What font is used for "Argo" in the header? When using the component library and styles, I get something slightly different:

Screenshot 2024-07-16 at 2 53 31 PM

Thanks.

astridu commented 1 month ago

@aaron-collier Good catch! That is definitely not the right font. It should be "Source Sans 3", semibold, size 36. Thank you for letting me know.

jcoyne commented 1 month ago

@astridu that looks like Source Sans 3 to me. How can you tell? Ah, it should have a closed tail "g"

aaron-collier commented 1 month ago

@jcoyne what I noticed was that the lower case g is different.