sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry
Other
20 stars 5 forks source link

Use component-library styles #4539

Closed jcoyne closed 1 month ago

jcoyne commented 1 month ago

Why was this change made?

Use the component-library

How was this change tested?

astridu commented 1 month ago

Button issues Seeing red buttons and/or links on these page. Buttons should be blue filled or blue outline:

Other issues

In design component library:

image
astridu commented 1 month ago

This is looking amazing! Thanks for taking the time and care to go through all of these. A few things:

  1. the garbage can icons should be blue, but I'm not sure if we've specified icon colors in the component library yet.
  2. the 'back' links on bulk actions: On second thought, this should probably be a Submit (blue filled button) and Cancel (outline button) to the right of it to be consistent with the Register actions.
  3. the 'Register' button on Register items is still hitting the bottom of the page. Could we give it some space so it's not touching the footer? Could we also put a blue outline 'Cancel' button to the right of the 'Register' button to make it consistent with the other Register actions?
  4. Could we make the 'cancel' link on the Register agreement page a blue outline button and to the right of the 'Create agreement' button?
  5. I also missed the facet buttons on the search results page. Those are still showing red, but Darcy defined a specific style for pills that I'm not sure are in the component library yet.
jcoyne commented 1 month ago

@astridu

These are now down aside from these two which I have ticketed separately as they are substantial additional work:

the 'back' links on bulk actions: On second thought, this should probably be a Submit (blue filled button) and Cancel (outline button) to the right of it to be consistent with the Register actions.

I also missed the facet buttons on the search results page. Those are still showing red, but Darcy defined a specific style for pills that I'm not sure are in the component library yet.