search

sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry
Other
20 stars 5 forks source link

Decouple the validation from the presentation of invalid fields #4577

Open jcoyne opened 1 month ago

jcoyne commented 1 month ago

Why was this change made?

We have css classes sprinkled into the validation code. We can just use the validation API instead. Doesn't depend on SASS.

andrewjbtw commented 1 month ago

The validation is now running immediately on page load. This is making the required fields light up in red and the cursor is placed in the label field. Sometimes my browser is taken to the label field and sometimes (as in the recording below) it's not taken there, but the validation message still appears on the screen.

https://github.com/user-attachments/assets/33504f7a-3b98-4218-a672-62021a6fb9b9

jcoyne commented 1 month ago

Andrew approved changes on Slack.