search

sul-dlss / argo

The administrative discovery interface for Stanford's Digital Object Registry
Other
21 stars 5 forks source link

Banner for old versions in Argo #4608

Closed astridu closed 2 months ago

astridu commented 3 months ago

We are requesting a few refinements to the banner that appears for old versions of items in Argo:

  1. Specify if version is a system or public version in the text: -Current: You are viewing an older version. -Proposed: You are viewing an older {system, public} version.

  2. Add a link to the current version in the banner:

    • Current: There is a link by the title to get back to the latest version, but we think it will be easier to locate if it's in the banner. image
  1. Visual design:
    • Current: Looks like the banner is in the old visual style. image
justinlittman commented 3 months ago

@astridu Is the "View latest version" supposed to open in a new tab as the box-arrow-up suggests? The component library uses a right pointing arrow but these designs show a left pointing arrow. Is that intended?

justinlittman commented 3 months ago

Also, should the existing "Back to current" link be removed?

justinlittman commented 3 months ago

Blocked by https://github.com/sul-dlss/argo/pull/4601

astridu commented 3 months ago

Copying @andrewjbtw on my response in case he wants to change any of these:

  1. Yes, open a new tab window
  2. Use whatever is in the component library. I grabbed this from a mockup so it might be old.
  3. Yes, back to current link should be removed. Thank you!
justinlittman commented 3 months ago

Seems odd that if you go from the current version to earlier versions you're in the same tab and you're switching between versions you're in the same tab, but then when you go back to the current version you open a new tab.

astridu commented 3 months ago

I was thinking if they wanted to compare the old vs. new, but then I looked at the PURL, and it opens in the same window. So let's go with that. Thanks for pointing that out. We can remove the icon next to the link and just have the link.

astridu commented 3 months ago

Oh, and note the link is black with underline for accessibility.

justinlittman commented 3 months ago

Super. Thanks for considering @astridu.