sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

move jp2Creator.create specs to expected spec file, and improve them. #106

Closed ndushay closed 2 years ago

ndushay commented 2 years ago

For reviewers: I have carefully checked that every spec removed from image_spec is now in jp2_creator spec, except for the skipped large image specs which we no longer need (verified with Tony C, in addition to the code now always creating a big tiff as the temporary tiff).

Why was this change made? 🤔

Also: Fixes #103 Closes #54

How was this change tested? 🤨

it was all specs, except for a typo in a raised error.

âš¡ âš  If this change has cross service impact, run integration tests that do IMAGE ACCESSIONING (e.g. create_preassembly_image_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡