sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

Changes strategy for creating temp tiff. #169

Closed justinlittman closed 1 year ago

justinlittman commented 1 year ago

refs https://github.com/sul-dlss/common-accessioning/issues/1079

Why was this change made? 🤔

To address problems with temporary tiffs by changing the approach for creating a temporary file. The previous approach created an open temporary file and then wrote to it separately (by the file path), so it is possible that in some cases this didn't go quite right. This creates a temporary directory to which the file can be written.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests that do IMAGE ACCESSIONING (e.g. create_preassembly_image_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡

Unit, Integration test

mjgiarlo commented 1 year ago

Much improved.