search

sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

fix an issue witha rubocop auto fix generating exceptions in some cases #19

Closed peetucket closed 5 years ago

peetucket commented 5 years ago

see https://github.com/rubocop-hq/rubocop/issues/1747

peetucket commented 5 years ago

Hmm, I wonder if we can put that require statement in the boot.rb file, which should then make it available to both the tests and the image class itself. The method definition embedded in spec_helper may need it (which is why it was added)?

jcoyne commented 5 years ago

@peetucket I think having it in the class will allow the tests to pass. That line was added in the same commit where $? -> $CHILD_PROCESS

peetucket commented 5 years ago

ok, removed