search

sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

[refactor] Extract Jp2Creator class #43

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

Why was this change made? 🤔

So that we separate the concerns about an image from the concern of making a JP2 derivative.

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests that do IMAGE ACCESSIONING (e.g. create_preassembly_image_spec) and/or test in [stage|qa] environment, in addition to specs. âš¡

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 4b5df65e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9% (0.7% change).

View more on Code Climate.