search

sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

vips instead of imagemagick for temporary tiffs and jp2 creation #65

Closed peetucket closed 2 years ago

peetucket commented 2 years ago

Holding for approval by Andrew and by Tony C.

Why was this change made? 🤔

Fixes #53 - use libvips instead of shelling out to imagemagick for generating test images and creating JP2s

BUT note that libvips has imagemagick as a dependency, so does not remove the need to have it installed on our servers

brew install libvips
==> Installing dependencies for vips: freetype, fontconfig, ninja, gdbm, ca-certificates, openssl@1.1, sqlite, python@3.10, meson, python@3.9, glib, xorgproto, libxcb, libx11, cfitsio, cgif, gmp, isl, mpfr, libmpc, zstd, gcc, hwloc, open-mpi, fftw, gobject-introspection, jpeg, libtiff, gdk-pixbuf, icu4c, harfbuzz, libaec, hdf5, little-cms2, openjpeg, ghostscript, imath, openexr, webp, libvmaf, aom, gnu-getopt, shared-mime-info, jasper, libomp, libraw, libtool, imagemagick, libexif, intltool, libgsf, libimagequant, libmatio, rust, fribidi, pango, librsvg, libspng, libxml2, mozjpeg, openslide, orc, cmake, nspr, nss, assimp, dbus, double-conversion, hunspell, libb2, libmng, md4c, pcre2, qt and poppler

Todo:

How was this change tested? 🤨

Updated tests

ndushay commented 2 years ago

@peetucket this needs a rebase. (whee!)

ndushay commented 2 years ago

note: merge with squash!! some commit messages aren't worth keeping :-)

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 670bb647 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.6% (1.0% change).

View more on Code Climate.

peetucket commented 2 years ago

Rebased from main --- no conflicts showing. I presume still [HOLD] for testing.

ndushay commented 2 years ago

Andrew has signed off on this PR, so what remains is for @calavano to sign off. I spoke with Tony this morning and he was going to work on this today.

calavano commented 2 years ago

@ndushay @peetucket I've done some testing and didn't find problems. It looks OK to move forward.

ndushay commented 2 years ago

Peter - I just merged this and will now do a major version release of the gem.