Closed peetucket closed 2 years ago
@peetucket this needs a rebase. (whee!)
note: merge with squash!! some commit messages aren't worth keeping :-)
Code Climate has analyzed commit 670bb647 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 92.3% (50% is the threshold).
This pull request will bring the total coverage in the repository to 93.6% (1.0% change).
View more on Code Climate.
Rebased from main --- no conflicts showing. I presume still [HOLD] for testing.
Andrew has signed off on this PR, so what remains is for @calavano to sign off. I spoke with Tony this morning and he was going to work on this today.
@ndushay @peetucket I've done some testing and didn't find problems. It looks OK to move forward.
Peter - I just merged this and will now do a major version release of the gem.
Holding for approval by Andrew and by Tony C.Why was this change made? 🤔
Fixes #53 - use libvips instead of shelling out to imagemagick for generating test images and creating JP2s
BUT note that libvips has imagemagick as a dependency, so does not remove the need to have it installed on our servers
Todo:
How was this change tested? 🤨
Updated tests