search

sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

Require 'vips' rather than 'ruby-vips' #73

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

Why was this change made? 🤔

Because this is the documented use in the ruby-vips readme: https://github.com/libvips/ruby-vips#example

How was this change tested? 🤨

CI

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 2ccbd8a6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.6% (0.0% change).

View more on Code Climate.

ndushay commented 2 years ago

Good catch, thanks. Needs a rebase, tho.

ndushay commented 2 years ago

approved modulo rebase (yes, again) and green status checks.