[refactor] Prefer kwargs to a hash argument

sul-dlss / assembly-image

Creates JP2 image derivatives of files.

Other

0 stars 1 forks source link

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

Hold please:

wait for functional changes to go out to prod first
will need to coordinate this with consumer apps (common-accessioning, was_robot_suite)

kwargs are better at verifying what you sent to the method was a valid option.

jcoyne commented 2 years ago

@ndushay this should not require any changes on the part of the consumers that I have identified. Can you show me where you think it would?

ndushay commented 2 years ago

@ndushay this should not require any changes on the part of the consumers that I have identified. Can you show me where you think it would?

whoops - my bad - i see we always call the method in the Image class. approving but it needs a rebase.