sul-dlss / assembly-image

Creates JP2 image derivatives of files.
Other
0 stars 1 forks source link

kakadu option -jp2_space sRGB: do we always want it set? never want it set? #98

Open ndushay opened 2 years ago

ndushay commented 2 years ago

We have this in the jp2_creator code:

      def jp2_create_command(source_path:, output:)
        options = []
        # since CMYK becomes sRGB in make_tmp_tiff, jp2_space option should be set for both;
        #   we're not sure at this time what happens for grayscale (or what Tony C. wants for grayscale)
        options << '-jp2_space sRGB' if image.srgb?

Options:

What should we do?