search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Make sourceId required for DROs #372

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

Why was this change made? 🤔

Fixes #369

How was this change tested? 🤨

unit tests

jcoyne commented 2 years ago

@justinlittman I'm just going on what Andrew said, but there is a facet in Argo for it: https://github.com/sul-dlss/argo/blob/main/app/controllers/catalog_controller.rb#L129 and it doesn't return any results:

Screen Shot 2022-03-30 at 2 20 28 PM
andrewjbtw commented 2 years ago

Not sure about any environment but unless something is hiding from the indexer in prod, I went through and assigned source ids to every item without them last year. They should show up as "Cocina conversion failed" in the Data Quality facet if a source id is missing.