sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Remove unused roles from AccessRole.name enumeration #393

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

dor-apo-reviewer, dor-apo-metadata, dor-apo-creator are never used:

See how these queries all return 0 results: https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_dor-apo-creator_ssim%3A& https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_person_dor-apo-creator_ssim%3A& https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_dor-apo-metadata_ssim%3A& https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_person_dor-apo-metadata_ssim%3A& https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_dor-apo-reviewer_ssim%3A& https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_person_dor-apo-reviewer_ssim%3A&

Compare to a role that is used like "dor-apo-viewer": https://sul-solr-prod-a.stanford.edu/solr/argo3_prod/select?fl=id&indent=true&q.op=OR&q=apo_role_person_dor-apo-viewer_ssim%3A*&

andrewjbtw commented 2 years ago

I've never seen those roles before and there's no place in the Argo UI to set them, so I think they can be dropped.

BTW, github is removing the * from the solr link so at first I couldn't understand why even the last query came up with no results.

jcoyne commented 2 years ago

@andrewjbtw thanks. I added an extra & to the end of the links to fix that problem.