search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Import the MODS to cocina descriptive translations #428

Closed jcoyne closed 2 years ago

jcoyne commented 2 years ago

Why was this change made? 🤔

So we can distribute this code. Namely to Argo so it can generate cocina from modsulator and we can retire the legacy API. Fixes #426

How was this change tested? 🤨

Tested in DSA, see https://github.com/sul-dlss/dor-services-app/pull/3917

jcoyne commented 2 years ago

@justinlittman a builder?

justinlittman commented 2 years ago

Cocina::Models::Builders::DescriptiveBuilder instead of Cocina::Models::ToFedora/FromFedora::Descriptive

jcoyne commented 2 years ago

It's not really a Builder pattern though. The builder is a specific thing: https://github.com/davidgf/design-patterns-in-ruby/blob/master/builder.md

jcoyne commented 2 years ago

@justinlittman I've added the missing specs. Let's just get this PR in as minimally changed from DSA. Then I want to make some changes as a follow up. I don't think that ToFedora or FromFedora are appropriate names anymore. Maybe ToMODS and FromMODS instead?

justinlittman commented 2 years ago

I don't see the new specs: image

What am I missing?

jcoyne commented 2 years ago

@justinlittman sorry, I thought you were talking about a different spec file.

ndushay commented 2 years ago

The "fixes #2426" refers to ... nothing. Is this related to sul-dlss/argo/issues/3551 as the original issue?

jcoyne commented 2 years ago

@ndushay that was supposed to be #426. Thanks for catching that.