search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Refactor: rename mapping folders "to_mods" and "from_mods", etc. #431

Closed ndushay closed 2 years ago

ndushay commented 2 years ago

Since mapping to and from MODS is going to be with us for a while, but Fedora is going away, we should change the name of these two folders in app/services/cocina

There is also inconsistency in class names:

should it always be name for the MODS element? for the Cocina class? For the originating object? We have, for example, "contributor" and "name_builder" classes in the from_fedora mods code.

justinlittman commented 2 years ago

Agree, but I would like to do this as part of the post-migration code-cleanup.

justinlittman commented 2 years ago

This should be under Cocina::Models::Mappings ...

ndushay commented 2 years ago

the h2 access, admin_metadata mappings: files need renaming to correspond to mods...

ndushay commented 2 years ago

And ... this is now done.