Handle access defaults in DarkValidator.

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)

https://sul-dlss.github.io/cocina-models/

3 stars 0 forks source link

Handle access defaults in DarkValidator. #446

Closed justinlittman closed 2 years ago

justinlittman commented 2 years ago

NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.

Why was this change made? 🤔

The Dark Validator wasn't taking into account defaults. (That is: DROAccess.new(view: 'dark') == DROAccess.new).

How was this change tested? 🤨

⚡ ⚠ If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡

Unit

andrewjbtw commented 2 years ago

What does this do?

justinlittman commented 2 years ago

@andrewjbtw From your perspective, hopefully nothing. However, it plugs a possible hole in the DarkValidator (which there is no reason to think was ever a problem except in tests).