search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

refactor: mods mapping classes no longer nested inside Descriptive class #449

Closed ndushay closed 2 years ago

ndushay commented 2 years ago

NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.

Why was this change made? 🤔

MODS maps to more than description in cocina; it also maps to access and admin. Also, fewer nested classes save lives, or at least some typing.

part of #431

No openapi.yml was harmed in the creation of this PR.

How was this change tested? 🤨

specs pass.

âš¡ âš  If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

jcoyne commented 2 years ago

I sort of liked the Descriptive namespace here because it was indicating that we are mapping to/from Cocina::Models::Description and not from the whole object (e.g. Cocina::Models::DRO)