search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Retain role in name subject in Cocina>MODS direction #465

Closed arcadiafalcone closed 2 years ago

arcadiafalcone commented 2 years ago

Example of role being dropped: compare Cocina and published purl MODS for name subject "Brandin, Alf" in dv559gn8984.

See spec at https://github.com/sul-dlss/cocina-models/blob/9c9c0ce7f9e8002aa1e80233d1a4741f0a7e0a06/spec/cocina/models/mapping/descriptive/mods/subject_name_spec.rb#L809

justinlittman commented 2 years ago

@arcadiafalcone I'm not entirely clear on this. Can you provide a spec?

arcadiafalcone commented 2 years ago

For the above example druid dv559gn8984, the output MODS is

<subject authority="lcsh">
  <topic>Stanford Shopping Center</topic>
  <name type="personal">
    <namePart>Brandin, Alf</namePart>
  </name>
  <topic>Stanford Industrial Park</topic>
</subject>

and should be

<subject authority="lcsh">
  <topic>Stanford Shopping Center</topic>
  <name type="personal">
    <namePart>Brandin, Alf</namePart>
    <role>
      <roleTerm type="text">interviewee</roleTerm>
    </role>
  </name>
  <topic>Stanford Industrial Park</topic>
</subject>