sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Make factories easier to distinguish and identify #466

Closed mjgiarlo closed 2 years ago

mjgiarlo commented 2 years ago

Why was this change made? 🤔

Fixes #454

Note: This commit will cause one spec in dor-services-app to fail but it ought to be easy to remediate once a cocina-models release goes out with this change included.

Failures:

  1) CocinaMigrationService#migrate when migration needed maps and persists
     Failure/Error: expect(ar_cocina_object.label).to eq('test object')
       Expected "factory DRO label" to eq "test object".
     # /media/mjg/44aee93d-a48a-4ad3-ae90-4b084bb04b69/rvm/gems/ruby-2.7.5@dor-services-app/gems/super_diff-0.9.0/lib/super_diff/rspec
/monkey_patches.rb:43:in `handle_failure'
     # ./spec/services/cocina_migration_service_spec.rb:41:in `block (4 levels) in <top (required)>'
     # /media/mjg/44aee93d-a48a-4ad3-ae90-4b084bb04b69/rvm/gems/ruby-2.7.5@dor-services-app/gems/webmock-3.14.0/lib/webmock/rspec.rb:3
7:in `block (2 levels) in <top (required)>'

Finished in 31.91 seconds (files took 3.57 seconds to load)
2088 examples, 1 failure, 5 pending

Failed examples:

rspec ./spec/services/cocina_migration_service_spec.rb:37 # CocinaMigrationService#migrate when migration needed maps and persists

How was this change tested? 🤨

CI + I pointed DSA at this branch (see above)