search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Implement mapping for name with altRepGroup and affiliation in Cocina>MODS direction #469

Closed arcadiafalcone closed 2 years ago

arcadiafalcone commented 2 years ago

Compare affiliation for name "Li, Yahong" in Cocina and purl MODS for zn746hz1696.

See spec at https://github.com/sul-dlss/cocina-models/blob/9c9c0ce7f9e8002aa1e80233d1a4741f0a7e0a06/spec/cocina/models/mapping/descriptive/mods/name_spec.rb#L293

justinlittman commented 2 years ago

@arcadiafalcone This spec uses parallelContributor, whereas other specs in the same file use parallelValue. Which is correct? Why are both modeling options?

justinlittman commented 2 years ago

It doesn't look like there is any mapping code that uses parallelContributor.

arcadiafalcone commented 2 years ago

parallelContributor was originally devised to support exact roundtripping of certain MODS structures for multilingual names. I eventually took a more relaxed approach for other instances where it was required, and will rewrite this spec to use parallelValue instead.