sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

remove vestigial ETD specific FileSet types #587

Closed ndushay closed 1 year ago

ndushay commented 1 year ago

HOLD - for coordinating with cocina-models release, yadda yadda

NOTE: this is not backwards compatible so it will be a major release (that's as serious as we get with cocina-models, AFAIK)

NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.

Why was this change made? 🤔

When we ported the ETD app away from Fedora3, we stopped using ETD specific FileSet types for newly created ETDs -- we use type "file" and distinguish among the 4 types of ETD files with the FileSet label.

The only objects that still had these obsolete ETD specific FileSet types were remediated in qa, stage and prod with the migrator in sul-dlss/dor-services-app/pull/4480 ... so now NO objects have these types.

The main idea of this whole exercise is to:

This PR is ... actually shrinking the cocina-models a tiny bit..

part of issue #302 (the other parts being creating a cocina-models release and all the cascading dependency updates for it.)

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡