While working on https://github.com/sul-dlss/dor_indexing_app/issues/992 for resource_type - I discovered that while we follow the same logic internally to determine this should provide a resource_type of Journal/Periodical, when translating the cocina to mods in order to use stanford-mods to determine the resource_type we do not look for the parallelValue and thus miss value="monthly" and type="frequency".
This checks if the note has a parallelValue and if so, uses value(s) found there to write the note.
Why was this change made? 🤔
While working on https://github.com/sul-dlss/dor_indexing_app/issues/992 for resource_type - I discovered that while we follow the same logic internally to determine this should provide a resource_type of
Journal/Periodical
, when translating the cocina to mods in order to usestanford-mods
to determine the resource_type we do not look for the parallelValue and thus missvalue="monthly"
andtype="frequency"
.This checks if the note has a parallelValue and if so, uses value(s) found there to write the note.
The Cocina for a note that has a parallelValue:
How was this change tested? 🤨
unit