search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Validate if values are whitespace only #639

Closed aaron-collier closed 1 year ago

aaron-collier commented 1 year ago

NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.

Why was this change made? 🤔

This is draft while wrapping up styling/refactoring...

How was this change tested? 🤨

âš¡ âš  If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

mjgiarlo commented 1 year ago

Wondering if this is the sort of change we might want to run against a sizable subset of prod data to see how this affects validation.

justinlittman commented 1 year ago

This should be validated against all items in all environments else chaos ensues.

aaron-collier commented 1 year ago

@mjgiarlo / @justinlittman agreed. I've marked as hold.

jcoyne commented 1 year ago

@aaron-collier how long will this take to validate? We're getting hammered with these errors again/still.

aaron-collier commented 1 year ago

@andrewjbtw here is a list of the druids that vail cocina validation with this change. 1073 objects. Should these be remediated before this change goes in?

validate-cocina.csv

aaron-collier commented 1 year ago

Removing hold per @andrewjbtw:

I think these are all fixed. I’m not sure what will happen if MARC-origin updates trigger this issue after we turn on the validation, but I don’t see how we can chase down where those past errors came from. It’s worth turning on the validation for spreadsheet imports and then seeing how we can catch the MARC-related issues if they happen again.

@mjgiarlo / @justinlittman ready for a follow up review.