Closed jmartin-sul closed 11 months ago
merging since @mjgiarlo approved and i took his non-blocking suggestion.
not urgent, but still interested in feedback for possible follow on touchups re:
docs/description_types.md
after running exe/generator generate
attribute?
makes optional
redundantRSpec/ExampleLength
@jmartin-sul ๐ฌ
merging since @mjgiarlo approved and i took his non-blocking suggestion.
๐๐ป
docs/description_types.md
after runningexe/generator generate
I think we ought to take whatever the generator generates (now and always---and if the generator isn't generating the right stuff, we should fix the generator logic).
- whether
attribute?
makesoptional
redundant
I believe attribute?
makes the key optional (can be missing) and optional
makes a value nil
able?
- whether to up the limit on (or disable)
RSpec/ExampleLength
I'm ๐ฏ on-board with the change you made.
@jmartin-sul ๐ฌ
ok, took that output and added it in the first commit in https://github.com/sul-dlss/cocina-models/pull/641
๐๐ป
at any rate, the tests already ensure that the value can be omitted entirely, so that does seem to indicate that
.optional
is superfluous in some way in this case.
Thanks for testing this!
NOTE: Changes to openapi.yml require updating openapi.yml for sdr-api and dor-services-app and generating models - see README.
Why was this change made? ๐ค
closes #637
How was this change tested? ๐คจ
unit tests
โก โ If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. โก