Closed jmartin-sul closed 10 months ago
@justinlittman and @mjgiarlo thanks for the feedback, implemented all suggestions, ready for another look
fixed the method i ripped off to be more concise, using the suggestion from this PR: https://github.com/sul-dlss/cocina-models/pull/645
Why was this change made? 🤔
this makes
LanguageTagValidator
operate more likeDarkValidator
, which we determined in slack discussion is likely desirable for real world validation usage:@mjgiarlo 💬
@jmartin-sul 💬
@mjgiarlo 💬
How was this change tested? 🤨
languageTag
mentioned in the linked slack discussion? and if so, merge this PR and cut a new patch release and update the argo PR to use that?âš¡ âš If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡