sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Convert gisAssemblyWF runtime checks to geo validators #662

Closed thatbudakguy closed 7 months ago

thatbudakguy commented 8 months ago

Currently, there are many checks that run during the gisAssemblyWF prior to transforming objects, which are failure points for the workflow.

In order to reduce the complexity of the gis-robot-suite and push these checks earlier in the data workcycle, we can convert them to custom geo validators.

Some examples:

This may help with issues like https://github.com/sul-dlss/argo/issues/3893 by ensuring bad data is caught earlier in the pipeline.

justinlittman commented 8 months ago

@thatbudakguy It's difficult to understand the necessary validation based on the existing validation code since it is expressed in terms of MODS. Can you specify the validation in terms of Cocina?