TitleBuilder corrections

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)

https://sul-dlss.github.io/cocina-models/

3 stars 0 forks source link

TitleBuilder corrections #672

Closed ndushay closed 8 months ago

ndushay commented 8 months ago

Why was this change made? 🤔

On the way to better discovery in Argo (see sul-dlss/dor_indexing_app/issues/1044), I got more information from Arcadia on the correct way to implement title building (See #657).

This PR

restores the reconstruction of structuredValue to order of occurrence
for main_title and full_title, gets BOTH parallel values (for equal weighting in search result ranking)

How was this change tested? 🤨

specs. Will test upcoming gem release with integration tests.

ndushay commented 8 months ago

Look at https://github.com/sul-dlss/dor_indexing/tree/check-cocina-title-chgs to see that these title changes fix the broken tests for what used to be the dor indexing app.

https://app.circleci.com/pipelines/github/sul-dlss/dor_indexing

BETTER: https://github.com/sul-dlss/dor_indexing/pull/7