search

sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

Validate for title.structuredValue.value having a type #675

Closed lwrubel closed 8 months ago

lwrubel commented 8 months ago

Why was this change made? 🤔

Validator to address https://github.com/sul-dlss/argo/issues/4279. This goes down one level of nesting (title.structuredValue) and also validates one level of relatedResource.title.structuredValue.

How was this change tested? 🤨

Unit. Ran bin/validate-cocina on QA, stage, and prod and there were no existing objects with this problem.

âš¡ âš  If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡

peetucket commented 8 months ago

@justinlittman if you happen to have a chance before departing and wanted to double-check this work before merging

lwrubel commented 8 months ago

@peetucket OK if I go ahead and merge this since I don't see any further notes from @justinlittman?