sul-dlss / cocina-models

Cocina repository data model (implemented in Ruby)
https://sul-dlss.github.io/cocina-models/
3 stars 0 forks source link

[HOLD] Fix validation of description values including title #681

Open lwrubel opened 7 months ago

lwrubel commented 7 months ago

Why was this change made? 🤔

HOLD because data in prod needs remediation. Follow-on to #675 (see https://github.com/sul-dlss/argo/issues/4279 and also https://github.com/sul-dlss/cocina-models/issues/424) to make sure that ValidationError is raised in several invalid title and other DescriptiveValue situations.

How was this change tested?

Unit. When running a dor-services-app instance locally in docker with the cocina-models branch, error is raised by DSA when an invalid update sent from Argo spreadsheet upload.

Ran bin/validate-cocina. There are 244 invalid druids in prod, none in qa or stage. Gave @arcadiafalcone the list of problem druids for remediation in https://github.com/sul-dlss/argo/issues/4279. They are all for "Multiple value, groupedValue, structuredValue, and parallelValue in description" errors.