@thatbudakguy there's probably some room to improve the clarity of the code. I made a few tweaks to the NavPlace code for it to fit here. Note that the NavPlace logic can handle extra characters in the coordinates string (it has a regex to extract the coordinates), so this validator does not care about that either.
Also probably good to add other invalid coordinates tests.
How was this change tested? 🤨
Unit tests
âš¡ âš If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡
thatbudakguy
commented
6 months ago
Why was this change made? 🤔
Refs #663.
@thatbudakguy there's probably some room to improve the clarity of the code. I made a few tweaks to the NavPlace code for it to fit here. Note that the NavPlace logic can handle extra characters in the coordinates string (it has a regex to extract the coordinates), so this validator does not care about that either.Also probably good to add other invalid coordinates tests.
How was this change tested? 🤨
Unit tests
âš¡ âš If this change has cross service impact, run integration tests and/or test in [stage|qa] environment, in addition to specs. âš¡